Drupal 9 Deprecated Code Report for Hacked module

After applying #2 there are still several errors:

Drupal check results

16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------------
  Line   hacked.report.inc
 ------ ------------------------------------------------------------------------------------------------------------------
  87     Call to deprecated constant UPDATE_CURRENT: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use
         \Drupal\update\UpdateManagerInterface::CURRENT instead.
  92     Call to deprecated constant UPDATE_NOT_CHECKED: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use
         \Drupal\update\UpdateFetcherInterface::NOT_CHECKED instead.
  98     Call to deprecated constant UPDATE_NOT_CHECKED: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use
         \Drupal\update\UpdateFetcherInterface::NOT_CHECKED instead.
 ------ ------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------
  Line   src/hackedProjectWebDevDownloader.php
 ------ ---------------------------------------------------------------------------------------------------------------------
  110    Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
  111    Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
 ------ ---------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------
  Line   src/hackedProjectWebDownloader.php
 ------ ---------------------------------------------------------------------------------------------------------------------
  36     Call to deprecated function file_directory_temp():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::getTempDirectory() instead.
  41     Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
  59     Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
 ------ ---------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------
  Line   src/hackedProjectWebFilesDownloader.php
 ------ ---------------------------------------------------------------------------------------------------------------------
  39     Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
  95     Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
  110    Call to deprecated function archiver_get_archiver():
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         get plugin.manager.archiver service from container and call getInstance()
         method on it. For example $archiver->getInstance(['filepath' => $file]);
 ------ ---------------------------------------------------------------------------------------------------------------------


 [ERROR] Found 11 errors

Please check the combined patch with fixes for all Drupal 9 compatibility fixes.

@driverok patch looks good, now there is no deprecated code.

Patch #6 looks good.

drupal-check -d web/modules/contrib/hacked
16/16 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

driverok, please fix patch to last dev version

Rerolled with core_version_requirement addition.

@joestewart, thanks a lot for the reroll.

Did a quick review of the file system stuff:
- non-static method 'deleteRecursive' should not be called statically. Given that @ivnsih choose to use the \Drupal::service('file_system') pattern when fixing #3147733: Automated Drupal 9 compatibility fixes, that would be just fine here. (See commit 40b974b)

I'll upload a patch to address #11 in a minute.
In the meantime here's my plain dumb reroll of #6, without any fix for file_unmanaged_delete_recursive(). Not very useful but I needed it because reasons. :-)

This is #10 with #11 addressed.

Thanks @Eric_A patch applies cleanly. Upgrade status is happy with it. Will test on D9 soon.

Looks like something changed. Drupal 9.2.1 error running the report.

https://www.drupal.org/node/2999951/revisions/view/11422137/11767365

1. hackedProjectWebFilesDownloader.php line 110

$archiver = \Drupal::service('plugin.manager.archiver')->getInstance(['filepath' => $file]);

2. Same file. Looks like this can be removed now:

use Drupal\Component\Utility\Unicode;

@Nathaniel, I ran into the same thing. It looks like there was a draft change record that didn't get the necessary revisions before publishing.

Here's a new patch. IMO removing the unused use is out of scope here so not including that.

Yep, that works! The patch applies. The report runs without any issues. I can view the file diff.