Problem/Motivation

A logic error in the scaffold component sometimes prevents the autoload.php file from being written. The code is inadvertently checking the directory containing the autoload file rather than the autoload file itself to determine whether the autoload file should be written. This can result in a false negative.

Proposed resolution

Fix the logic in the code.

Remaining tasks

None.

Follow-on Tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

The Drupal Scaffold component sometimes did not write the autoload.php file as it was supposed to.

CommentFileSizeAuthor
#3 3075621-3.patch2.72 KBgreg.1.anderson
#2 3075621-2.patch1.75 KBgreg.1.anderson

Comments

greg.1.anderson created an issue. See original summary.

greg.1.anderson’s picture

greg.1.anderson commented
Status: Active » Needs review
StatusFileSize
new 3075621-2.patch1.75 KB

Here is a failing test.

greg.1.anderson’s picture

greg.1.anderson commented
StatusFileSize
new 3075621-3.patch2.72 KB

Here is a fix for the bug that is proven correct by the test from #2.

The last submitted patch, 2: 3075621-2.patch, failed testing. View results

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

Nice catch, and clearly proven fix.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed 0039c52 and pushed to 8.8.x. Thanks!

  • larowlan committed 0039c52 on 8.8.x 
    Issue #3075621 by greg.1.anderson: Scaffold plugin sometimes fails to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.