This is a useful module, thanks! It would be great if it would not only work for nodes, but other entity types as well. E.g. for group navigation the smart mode would be very useful.

Comments

anruether created an issue. See original summary.

saesa’s picture

Delighted that you like the module, thanks! With group navigation are you referring to the group module?

anruether’s picture

Yes! One thing I hoped to learn was if you would expect the smart mode the work in that (and other contexts) as well.

saesa’s picture

Yes, I already did it once for something concrete, it could make it work correctly with the group module.

saesa’s picture

Assigned: Unassigned » saesa
saesa’s picture

Assigned: saesa » Unassigned
stephencross’s picture

I'm interested in using this with Media. Do you expect to have this working with other entity types in the future?

Thanks.

bbu23’s picture

Assigned: Unassigned » bbu23
bbu23’s picture

StatusFileSize
new25.64 KB

Hello everybody,

I've prepared a first version of this patch and I'm looking for some feedback because I didn't test with all possible entities, ofc. So, I kindly ask the people who are interested in this evolution, but also the people that are currently using the module to check for possible regressions and to verify as many new entity types as possible.

I added a validation for the "custom url" fields, so if people don't like this or are affected by this, I can remove it. I also removed the language from the Url builder because it's specified that if we don't send the language, then Drupal will use the current language.

Please run the update after applying the patch!!
drush updb

bbu23’s picture

Status: Active » Needs review
saesa’s picture

Status: Needs review » Needs work

@bbu23 could you update the patch for to testing?

bbu23’s picture

@saesa sure, I'll do it shortly.

bbu23’s picture

StatusFileSize
new24.73 KB

I've updated the patch.

bbu23’s picture

Status: Needs work » Needs review
bbu23’s picture

Assigned: bbu23 » Unassigned

  • 2d48728 committed on 8.x-1.x
    Issue #3075606 by bbu23: Make it usable for other entity types as well
    
saesa’s picture

Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.