Code in ctools_component_features_export_render():
$code = explode('}', implode($code, "{\n"));
Looks wrong?
Interestingly it does work! https://3v4l.org/5h9GH
But not for long. Starting PHP 7.4, we will get this deprecation notice:
Deprecated: implode(): Passing glue string after array is deprecated. Swap the parameters in /in/5h9GH on line 3
Let's stick to the normal way of calling implode().
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | features-7.x-2.x-3075578-4-implode-arg-order.patch | 574 bytes | donquixote |
Comments
Comment #2
donquixote commentedWhich also means this can be fixed without fear of regressions.
Comment #4
donquixote commentedComment #5
damienmckennaComment #6
jacob.embree commentedComment #7
hargobindThe patch in #4 looks good, and should be simple enough to commit without tests. RTBC++
Comment #8
donquixote commentedThanks @jacob.embree and @hargobind for reviewing and testing!
Comment #10
donquixote commented