After install I get the following error across all pages. Any suggestions?

Declaration of Drupal\simplenews\Spool\SpoolStorage::addIssue($issue) must be compatible with Drupal\simplenews\Spool\SpoolStorageInterface::addIssue(Drupal\Core\Entity\ContentEntityInterface $issue) in /sites/all/modules/simplenews/src/Spool/SpoolStorage.php on line 17

CommentFileSizeAuthor
#2 simplenews-spoolstorage-3075393-2.patch512 bytesagoja

Comments

mrdrill created an issue. See original summary.

agoja’s picture

agoja commented
StatusFileSize
new simplenews-spoolstorage-3075393-2.patch512 bytes

Hello,

Patch with a fix.

mrdrill’s picture

mrdrill commented

Thank you, worked great!

mrdrill’s picture

mrdrill commented
Status: Active » Fixed
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 8.x-2.0-alpha2 » 8.x-2.x-dev
Status: Fixed » Reviewed & tested by the community

It will only be set to fixed after committed, I think the error only happens on 7.1 and older.

adamps’s picture

adamps commented
Title: SpoolStorage addIssue » PHP 7.2 error for SpoolStorage addIssue
Category: Support request » Bug report
Priority: Normal » Major
adamps’s picture

adamps commented
Issue tags: +Plan to commit
tr’s picture

tr commented

See also my comment in #3078855-2: Simplenews prevents cron from running.

I believe the patch in #2 fixes this issue, and that was confirmed by the original reporter of the problem back in #3.

  • AdamPS committed 884f1ce on 8.x-2.x authored by agoja 
    Issue #3075393 by agoja: PHP 7.2 error for SpoolStorage addIssue
adamps’s picture

adamps commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Plan to commit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.