15/15 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ----------------------------------------------------------------------
Line abtestui.module
------ ----------------------------------------------------------------------
61 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
72 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
83 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line modules/abtestui_google_analytics/abtestui_google_analytics.install
------ ----------------------------------------------------------------------
18 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Form/ABTestDeleteForm.php
------ ----------------------------------------------------------------------
101 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Form/ABTestForm.php
------ ----------------------------------------------------------------------
635 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
638 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

[ERROR] Found 7 errors

CommentFileSizeAuthor
#5 abtestui-3075019-2.patch4 KBrudranil29
#2 abtestui-3075019-1.patch3.78 KBrudranil29

Comments

joy29 created an issue. See original summary.

rudranil29’s picture

rudranil29 commented
Issue summary: View changes
StatusFileSize
new abtestui-3075019-1.patch3.78 KB

remove deprecated method

rudranil29’s picture

rudranil29 commented
Assigned: rudranil29 » Unassigned
Status: Active » Needs review
mhavelant’s picture

mhavelant commented
Status: Needs review » Needs work

Hi,

Thank you for the patch! The messenger service was added in Drupal 8.5 (See: Change record). If we want to replace deprecations regarding this, we also need to add a lower bound in the info.yml and composer.json of the module.

rudranil29’s picture

rudranil29 commented
Assigned: Unassigned » rudranil29
Status: Needs work » Needs review
StatusFileSize
new abtestui-3075019-2.patch4 KB

here i changed the info.yml for minimum system version.

pifagor’s picture

pifagor commented
Status: Needs review » Reviewed & tested by the community

Look good

  • mhavelant committed e0452a7 on 8.x-1.x 
    Issue #3075019 by joy29: Deprecated Method used
mhavelant’s picture

mhavelant commented
Status: Reviewed & tested by the community » Fixed

Thank you, fixed in beta8.

pifagor’s picture

pifagor commented
pifagor’s picture

pifagor commented

Dear @mhavelant

It would be great to note the contribution to the module and work on issues by noting everyone present and thus giving credits
Thanks

mhavelant’s picture

mhavelant commented

@pifagor sorry, I thought I checked the checkbox for everyone, but apparently D.org didn't think so.

pifagor’s picture

pifagor commented

Thanks

PS: https://www.drupal.org adds credits only to the patch author.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.