This Ckeditor Nofollow module provides a widget to add rel="nofollow" to links using the icon, It provides content editor an option to add no-follow attributes to desire links.

Installation
Install the module as every other module.

Configuration
1. Navigate to Administration > Extend and enable the module.
2. Navigate to Administration > Configuration > Content authoring >
Text formats and editors.
3. Select "Configure" for the text format were you would like to
add this feature.
4. Move Ckeditor Nofollow icon from the "Available buttons" into the
"Active toolbar" to enable it.

Project link
https://www.drupal.org/project/ckeditor_nofollow

Git intructions
git clone --branch 8.x-1.x git@git.drupal.org:project/ckeditor_nofollow.git

Pareview
https://pareview.sh/pareview/https-git.drupal.org-project-ckeditor_nofol...

Comments

mohit_parashar created an issue. See original summary.

mohit_parashar’s picture

mohit_parashar commented
Issue summary: View changes
mohit_parashar’s picture

mohit_parashar commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Issue summary: View changes
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Needs work

Thank you for the contribution!

Please fix the ESLint issues mentioned on Pareview checklist page:
* ESLint has found some issues with your code (please check the JavaScript coding standards).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

A review should report what is wrong in the code, not simply give a link to a page listing what needs to be fixed. A short description such as The code doesn't follow the Drupal coding standards in some points is fine.

er.garg.karan’s picture

er.garg.karan
Primary language English
Location Chandigarh
commented
Issue tags: +Coding standards

Review for version 8.x-1.x

  1. Typo at line 4:46 in js/plugins/nofollow/plugin.js
  2. Empty line 10 can be removed in js/plugins/nofollow/plugin.js
phthlaap’s picture

phthlaap commented
Status: Needs review » Needs work

1 . Please help to fix the issues reported by PAReview:

ESLint has found some issues with your code (please check the JavaScript coding standards).
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 7, Error - Unexpected labeled statement. (no-labels)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 7, Error - 'canUndo:' is defined but never used. (no-unused-labels)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 16, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 25, col 20, Error - Unexpected use of comma operator. (no-sequences)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 42, col 66, Error - Properties shouldn't be quoted as all quotes are redundant. (quote-props)
/var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/plugins/nofollow/plugin.js: line 45, col 9, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)

6 problems
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -Coding standards
mohit_parashar’s picture

mohit_parashar commented
Status: Needs work » Needs review

Fixed js standard issue.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Reviewed & tested by the community

Thank you for the contribution!

I have not found any security related issues in the code.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed
Issue tags: +PAreview: single application approval 
/*
 *  # Nofollow Plugin for CKEditor #
 *
 *  (C) Copyright Mohit Parashar (all rights reserverd)
 *  MIT License
 *
 *
 */

When you consented to the Git agreement, you agreed to only commit code licensed as GPL-2.0+ and non-code assets licensed with GPL friendly licenses.

Thank you for your contribution! I am going to update your project.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.