php drupal-check.phar modules/contrib/warmer/
 21/21 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------------- 
  Line   src/Commands/WarmerCommands.php                                            
 ------ --------------------------------------------------------------------------- 
         Class Drush\Commands\DrushCommands not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/WarmerPluginBase.php                                                                                                   
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  24     Class Drupal\warmer\Plugin\WarmerPluginBase implements deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface.  
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors
CommentFileSizeAuthor
#6 deprecated-3074742-5.patch1.38 KBrealityloop
#4 deprecated-3074742-4.patch1.36 KBrealityloop
#2 deprecated-3074742-2.patch1.05 KBsergiu stici

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

sergiu stici commented
Status: Active » Needs review
StatusFileSize
new deprecated-3074742-2.patch1.05 KB

Please review.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Let's also add compatibility with D9.

realityloop’s picture

realityloop commented
StatusFileSize
new deprecated-3074742-4.patch1.36 KB

@e0ipso added core compatibility to info file.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: deprecated-3074742-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

realityloop’s picture

realityloop commented
Status: Needs work » Needs review
StatusFileSize
new deprecated-3074742-5.patch1.38 KB

  • slv_ committed 211cf09 on 8.x-1.x authored by realityloop 
    Issue #3074742 by realityloop, Sergiu Stici: Deprecated Code Report
slv_’s picture

slv_ commented

Committed, thanks all!

slv_’s picture

slv_ commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.