The D8 version does not yet have tests in place for it. Those should be seen as a blocker to releasing a full 8.x-1.0 version.

CommentFileSizeAuthor
#10 i3074237-6.patch4.75 KBbarrett
#8 i3074237-5.patch4.14 KBattiks
#6 i3074237-4.patch3.5 KBattiks
#5 i3074237-3.patch3.5 KBattiks
#3 i3074237-2.patch2.27 KBattiks
#2 i3074237.patch1.8 KBattiks

Comments

Barrett created an issue. See original summary.

attiks’s picture

attiks commented
Status: Active » Needs review
StatusFileSize
new i3074237.patch1.8 KB
attiks’s picture

attiks commented
StatusFileSize
new i3074237-2.patch2.27 KB

Add missing group

Status: Needs review » Needs work

The last submitted patch, 3: i3074237-2.patch, failed testing. View results

attiks’s picture

attiks commented
StatusFileSize
new i3074237-3.patch3.5 KB

- Schema added
- Test 200, 418 and 503

attiks’s picture

attiks commented
Status: Needs work » Needs review
StatusFileSize
new i3074237-4.patch3.5 KB

Status: Needs review » Needs work

The last submitted patch, 6: i3074237-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

attiks’s picture

attiks commented
Status: Needs work » Needs review
StatusFileSize
new i3074237-5.patch4.14 KB

Add a real node to test against

attiks’s picture

attiks commented
Parent issue: » #3134141: Create a stable release
barrett’s picture

barrett commented
StatusFileSize
new i3074237-6.patch4.75 KB

Thank you for the patches, @attiks. I've rolled a new version based on your #5 patch that cleans up some D7-era issues (use $this-t() instead of t(), use new array syntax) and makes some pedantic changes like making test conditions more explicit in code and reordering them a bit.

  • Barrett committed 8b3c1ec on 8.x-1.x authored by attiks 
    Issue #3074237 by attiks, Barrett: Port tests to D8 version
barrett’s picture

barrett commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.