I have added views integration as we discussed here: https://www.drupal.org/project/eu_cookie_compliance/issues/3071961
Note: Since I added views it becomes as a dependency along ctools.

CommentFileSizeAuthor
#8 views_integration-3073989-8.patch3.78 KBjunkuncz
#2 views_integration-3073989-1.patch4.01 KBjunkuncz

Comments

junkuncz created an issue. See original summary.

junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
StatusFileSize
new views_integration-3073989-1.patch4.01 KB
junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Status: Active » Needs review
svenryen’s picture

svenryen commented

Do we need to mark views as a dependency? Can't the hooks just be there and used whenever Views is present?

(Actually hard to imagine a Drupal site without Views, but I don't want to add the dependency for people who are not using the feature.)

svenryen’s picture

svenryen commented

Short array syntax is only available from PHP 5.4 onwards, and we need to support 5.2.something for contrib (We actually do have users on 5.2, because I've come across this issue before, and had to redo a few array notations that slipped past in a previous patch).

svenryen’s picture

svenryen commented
Status: Needs review » Needs work
junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented

Absolutely valid reasons. I’m gonna take care about them!

Balint

junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
StatusFileSize
new views_integration-3073989-8.patch3.78 KB

Updated patch is attached!

junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Status: Needs work » Needs review
svenryen’s picture

svenryen commented
Status: Needs review » Closed (duplicate)

This is a duplicate of #3071961: Retrieve what is stored.