src/Form/LimitDomainAccessByRoleConfigForm.php
line 46 Possible useless method overriding detected

CommentFileSizeAuthor
#2 codesniffer_remove_useless_method.3072853-2.patch589 byteslolandese

Issue fork limit_domain_access_by_role-3072853

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new codesniffer_remove_useless_method.3072853-2.patch589 bytes
lolandese’s picture

lolandese commented
Status: Needs review » Reviewed & tested by the community

The concerning method was an unused config form validation. It makes indeed sense to remove it as it clutters the code unnecessarily.

  • lolandese committed 219a8d6 on 8.x-1.x 
    Issue #3072853 by lolandese: PHPCS Warning: Possible useless method...
lolandese’s picture

lolandese commented
Status: Reviewed & tested by the community » Fixed

Committed. We also enable automated testing on commits and issues as you can see above as the green bar showing under the supplied patch. It does not do much yet but at least checks if patches are applied cleanly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Rashmisoni made their first commit to this issue’s fork.