The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Please remove unused variable in entity_embed.module:
FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/entity_embed.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
155 | WARNING | Unused variable $allowed_html.
--------------------------------------------------------------------------| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3072669-fix-unused-variable.patch | 632 bytes | dave reid |
| #2 | 3072669-2.patch | 643 bytes | vuil |
Comments
Comment #2
vuilComment #3
vuilComment #4
dharti patel commentedComment #5
dharti patel commentedTested the #2 patch and after applying patch remove unused variable errors are eliminate from entity_embed.module file. Need to move to RTBC.
Thanks!
Comment #6
dave reidChecking the value against not null seems odd. We may just need to revisit this. Should it be removed? Should it just be a not-empty check (not necessarily a null check)?
Comment #7
dave reidUpdated version with simplified if statement.
Comment #8
dave reidComment #10
dave reidCommitted #8 to 8.x-1.x.