CommentFileSizeAuthor
#8 Screenshot 2019-10-15 at 5.09.16 PM.png1.65 MBkishor_kolekar
#8 Screenshot 2019-10-15 at 5.09.02 PM.png1.77 MBkishor_kolekar
#8 Screenshot 2019-10-15 at 5.08.29 PM.png59.34 KBkishor_kolekar
#5 simplytest_import-3072140-5.patch10.2 KBabhisekmazumdar
#7 interdiff_5-7.txt3.8 KBabhisekmazumdar
#7 simplytest_import-3072140-7.patch11.08 KBabhisekmazumdar

Comments

sumitmadan created an issue. See original summary.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Assigned: Unassigned » abhisekmazumdar
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

Awesome -- thank you for looking into this, @abhisekmaz.

Please note that several of the old import options on the form are no longer needed for this port and can be considered legacy. The key requirement is we need to pull in a full set of projects against the set of supported major Drupal versions (config form).

There is an automated import now that uses the batch API. I would recommend we just do that and see how far we get :)

I can do a deeper dive or can answer specific questions.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented

Hi @nerdstein
Thanks for all the inputs. Here what I'm going to do with the config form. I will add the settings for Count of projects to import per operation. Also will create a batch process for importing all the project, themes and distributions automatically. Will use the same table schema for all this process.
I will get back to you if I need any more inputs.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Active » Needs review
StatusFileSize
new simplytest_import-3072140-5.patch10.2 KB

Hi @nerdstein
Need your feedback. Kindly review.

sumitmadan’s picture

sumitmadan commented
Status: Needs review » Needs work 
  1. +++ b/modules/simplytest_import/simplytest_import.module
@@ -0,0 +1,65 @@
+function batch_fetch_import_process($index, $type, &$context) {

    Please prefix all the function name with the module name. 

  2. +++ b/modules/simplytest_import/simplytest_import.routing.yml
@@ -0,0 +1,7 @@
+  path: '/simplytest_import/form/import'

    It should be an admin form I believe. 

  3. +++ b/modules/simplytest_import/src/Form/ImportForm.php
@@ -0,0 +1,154 @@
+    return 'automatic_import_form';

    Form id should also be prefixed with module name. 

  4. +++ b/modules/simplytest_import/src/Form/ImportForm.php
@@ -0,0 +1,154 @@
+      $count = 5;

    Seems you want to keep the commented code and remove this code.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new simplytest_import-3072140-7.patch11.08 KB
new interdiff_5-7.txt3.8 KB

Added admin Menu under admin/config. Also made the suggested changes.
Thank You @sumitmadan for the guidance and review.

kishor_kolekar’s picture

kishor_kolekar commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2019-10-15 at 5.08.29 PM.png59.34 KB
new Screenshot 2019-10-15 at 5.09.02 PM.png1.77 MB
new Screenshot 2019-10-15 at 5.09.16 PM.png1.65 MB

@abhisekmazumdar,
I have tried importing modules and themes attaching the screenshot below.

everything works fine for me.

Thanks!

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Patch (to be ported)

Thank you all so much - merging this in now!

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Patch (to be ported) » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Assigned: abhisekmazumdar » Unassigned