According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

Patch to follow, thanks!

CommentFileSizeAuthor
#2 o365-info-3071989-2.patch779 bytesalonaoneill

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
StatusFileSize
new o365-info-3071989-2.patch779 bytes
Willtg’s picture

Willtg commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency name-spacing aligns with Drupal documentation standards. Applied when tested with STM.
Marking as RTBC
Thank you for working on the module!

  • fabianderijk committed 137b0b6 on 8.x-1.x 
    Fixed [#3071989] and added a return for the login method
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Reviewed & tested by the community » Fixed

Fixed issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.