When setting primary (and others) in theme-options.yml it's not taken everywhere.

Instead of using

primary: '#COLCOD'

this needs to used

theme-colors:
  primary: '#COLCOD'

or even

primary: '#COLCOD'

theme-colors:
  primary: $primary

This should be adopted in the inital theme-option.yml file.

CommentFileSizeAuthor
#2 3071906-set_theme_colors_everywhere-2.patch400 bytesytsurk

Comments

ytsurk created an issue. See original summary.

ytsurk’s picture

ytsurk
Location Switzerland
commented
StatusFileSize
new 3071906-set_theme_colors_everywhere-2.patch400 bytes

Like this - Maybe we should even add more variables in this initial file to show the power of it ...

ytsurk’s picture

ytsurk
Location Switzerland
commented
Status: Active » Needs review
pivica’s picture

pivica commented

Yeah, we did this fix in Primer but i still didn't port this back to bs_base. Will check this in more details during the week.

  • pivica committed 89f9c12 on 8.x-1.x authored by ytsurk 
    Issue #3071906 by ytsurk: To really overwrite theme-colors the array...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Some stuff leaked from Primer into theme-options.yml hardcoded template (that color maps), not good ;). I've created a follow-up to clean this #3099329: Improve generator theme-options.yml content generation.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.