CommentFileSizeAuthor
#9 interdiff-2-8.txt3.41 KBnaresh_bavaskar
#8 3071642-8.patch1.09 KBnaresh_bavaskar
#5 Greater_then.png61.3 KBabhisekmazumdar
#5 Less_then.png67.42 KBabhisekmazumdar
#2 views_conditional-less_than_equal_to-3071642-2.patch3.29 KBsnehalgaikwad

Comments

snehalgaikwad created an issue. See original summary.

snehalgaikwad’s picture

snehalgaikwad commented
StatusFileSize
new views_conditional-less_than_equal_to-3071642-2.patch3.29 KB

Added two more conditions, less than equal to and greater than equal to.

snehalgaikwad’s picture

snehalgaikwad commented
Assigned: snehalgaikwad » Unassigned
snehalgaikwad’s picture

snehalgaikwad commented
Status: Active » Needs review
abhisekmazumdar’s picture

abhisekmazumdar
he/him
Primary language English
Location India
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Less_then.png67.42 KB
new Greater_then.png61.3 KB

+1 RTBC

For Greater then Equal

For Less the Equal

shelane’s picture

shelane
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

It looks as though this would change what the behavior for existing views. The patch needs an update hook to make those updates so that users would not end up with completely wrong views results based on different conditions than what they set. So if someone had 12 => 'Length Less than' set, it would start to behave as 12 => 'Length NOT equal to'

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: Unassigned » naresh_bavaskar
naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
Assigned: naresh_bavaskar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3071642-8.patch1.09 KB

Please review the patch, i have made some changes where we dont need to write update hook @shelane (might $conditions sequence 13th and 14th looks bad)

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
commented
StatusFileSize
new interdiff-2-8.txt3.41 KB

added interdiff

  • shelane committed 8abf14b on 8.x-1.x 
    Issue #3071642 by naresh_bavaskar: Condition less than or equal and...
shelane’s picture

shelane
Primary language English
commented
Status: Needs review » Fixed
shelane’s picture

shelane
Primary language English
commented

I decided to do a bit of refactoring, so the committed code does not match your patch. It was definitely worth adding.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.