php drupal-check.phar modules/contrib/box/
 60/60 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   box.install                                                                                                   
 ------ -------------------------------------------------------------------------------------------------------------- 
  58     Call to deprecated method applyUpdates() of class Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface.  
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------- 
  Line   modules/box_clone/box_clone.module            
 ------ ---------------------------------------------- 
  56     Call to deprecated function format_string().  
 ------ ---------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   modules/box_clone/src/Form/BoxCloneForm.php        
 ------ --------------------------------------------------- 
  39     Call to deprecated function drupal_set_message().  
  50     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------- 
  Line   modules/graphql_box/src/Plugin/GraphQL/Fields/BoxByMachineName.php                                 
 ------ --------------------------------------------------------------------------------------------------- 
         Class Drupal\graphql\Plugin\GraphQL\Fields\FieldPluginBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------- 
  Line   src/Controller/BoxController.php                                                           
 ------ ------------------------------------------------------------------------------------------- 
  32     Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase.  
  33     Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase.  
  48     Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase.  
  49     Call to deprecated function format_date().                                                 
  67     Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase.  
  95     Call to deprecated method l() of class Drupal\Core\Controller\ControllerBase.              
  98     Call to deprecated method link() of class Drupal\Core\Entity\EntityInterface.              
 ------ ------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/views/field/BoxBulkForm.php                                                                               
 ------ --------------------------------------------------------------------------------------------------------------------- 
  12     Class Drupal\box\Plugin\views\field\BoxBulkForm extends deprecated class Drupal\system\Plugin\views\field\BulkForm.  
 ------ --------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------- 
  Line   src/Plugin/views/field/RevisionLink.php                                           
 ------ ---------------------------------------------------------------------------------- 
  27     Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface.  
 ------ ---------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------ 
  Line   src/Plugin/views/wizard/Box.php                             
 ------ ------------------------------------------------------------ 
  220    Call to deprecated function entity_get_form_display().      
  221    Call to deprecated method entityManager() of class Drupal.  
 ------ ------------------------------------------------------------ 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/src/Functional/EntityTest.php                                                
 ------ ----------------------------------------------------------------------------------- 
  77     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.  
 ------ ----------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------- 
  Line   tests/src/Functional/TypeTest.php                                                  
 ------ ----------------------------------------------------------------------------------- 
  57     Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.  
 ------ ----------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 18 errors                  

Comments

Sergiu Stici created an issue. See original summary.

sergiu stici’s picture

Status: Active » Needs review
StatusFileSize
new10.33 KB

Here is the patch, please review.

kswamy’s picture

Status: Needs review » Needs work
Issue tags: +ContributionWeekend2020

Attached patch does not apply against latest version. Below is the updated list of issues against the latest version

62/62 [============================] 100%

------ --------------------------------------------------------------------------------------------------------------
Line box.install
------ --------------------------------------------------------------------------------------------------------------
59 Call to deprecated method applyUpdates() of class Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface:
in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Entity\EntityDefinitionUpdateManagerInterface::getChangeList()
and execute each entity type and field storage update manually instead.
------ --------------------------------------------------------------------------------------------------------------

------ ---------------------------------------------------------
Line modules\box_clone\box_clone.module
------ ---------------------------------------------------------
56 Call to deprecated function format_string():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Component\Render\FormattableMarkup instead.
------ ---------------------------------------------------------

------ ----------------------------------------------------------------------
Line modules\box_clone\src\Form\BoxCloneForm.php
------ ----------------------------------------------------------------------
39 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
50 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------
Line modules\graphql_box\src\Plugin\GraphQL\Fields\BoxByMachineName.php
------ ------------------------------------------------------------------------------------------
Class Drupal\graphql_core\GraphQL\FieldPluginBase not found and could not be autoloaded.
------ ------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------
Line modules\graphql_box\src\Plugin\GraphQL\Fields\BoxMachineName.php
------ ------------------------------------------------------------------------------------------
Class Drupal\graphql_core\GraphQL\FieldPluginBase not found and could not be autoloaded.
------ ------------------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------------------------------
Line src\BoxListBuilder.php
------ ------------------------------------------------------------------------------------------------------
18 Usage of deprecated trait Drupal\Core\Routing\LinkGeneratorTrait in class Drupal\box\BoxListBuilder:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Link instead.
41 Call to deprecated method l() of class Drupal\box\BoxListBuilder:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
------ ------------------------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------
Line src\BoxPermissions.php
------ -----------------------------------------------------------------------------------------------------
15 Usage of deprecated trait Drupal\Core\Routing\UrlGeneratorTrait in class Drupal\box\BoxPermissions:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Url instead.
------ -----------------------------------------------------------------------------------------------------

------ -------------------------------------------------------------------------------------------
Line src\Controller\BoxController.php
------ -------------------------------------------------------------------------------------------
30 Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Most of the time static::entityTypeManager() is supposed to be used
instead.
31 Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Most of the time static::entityTypeManager() is supposed to be used
instead.
46 Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Most of the time static::entityTypeManager() is supposed to be used
instead.
47 Call to deprecated function format_date():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::service('date.formatter')->format().
65 Call to deprecated method entityManager() of class Drupal\Core\Controller\ControllerBase:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Most of the time static::entityTypeManager() is supposed to be used
instead.
93 Call to deprecated method l() of class Drupal\Core\Controller\ControllerBase:
in drupal:8.0.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\Link::fromTextAndUrl() instead.
96 Call to deprecated method link() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\EntityInterface::toLink()->toString() instead.
------ -------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src\Form\BoxDeleteMultipleForm.php
------ ----------------------------------------------------------------------
192 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line src\Form\BoxForm.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
108 Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use \Drupal::time()->getRequestTime();
125 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
130 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ -----------------------------------------------------------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src\Form\BoxRevisionDeleteForm.php
------ ----------------------------------------------------------------------
76 Call to deprecated function format_date():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::service('date.formatter')->format().
110 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
110 Call to deprecated function format_date():
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::service('date.formatter')->format().
------ ----------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line src\Form\BoxRevisionRevertForm.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
123 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
144 Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use \Drupal::time()->getRequestTime();
------ -----------------------------------------------------------------------------------------------------------------------------------------------

------ -----------------------------------------------------------------------------------------------------------------------------------------------
Line src\Form\BoxRevisionRevertTranslationForm.php
------ -----------------------------------------------------------------------------------------------------------------------------------------------
113 Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0 and is removed from drupal:9.0.0. Use \Drupal::time()->getRequestTime();
------ -----------------------------------------------------------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src\Form\BoxTypeForm.php
------ ----------------------------------------------------------------------
144 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
150 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src\Plugin\Block\BoxView.php
------ ----------------------------------------------------------------------
110 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------

------ ---------------------------------------------------------------------------------------------------------------------
Line src\Plugin\views\field\BoxBulkForm.php
------ ---------------------------------------------------------------------------------------------------------------------
12 Class Drupal\box\Plugin\views\field\BoxBulkForm extends deprecated class Drupal\system\Plugin\views\field\BulkForm:
in drupal:8.5.0 and is removed from drupal:9.0.0. Use
\Drupal\views\Plugin\views\field\BulkForm instead.
------ ---------------------------------------------------------------------------------------------------------------------

------ ----------------------------------------------------------------------------------
Line src\Plugin\views\field\RevisionLink.php
------ ----------------------------------------------------------------------------------
27 Call to deprecated method urlInfo() of class Drupal\Core\Entity\EntityInterface:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Entity\EntityInterface::toUrl() instead.
------ ----------------------------------------------------------------------------------

------ --------------------------------------------------------------------------
Line src\Plugin\views\wizard\Box.php
------ --------------------------------------------------------------------------
220 Call to deprecated function entity_get_form_display():
in drupal:8.8.0 and is removed from drupal:9.0.0. Use
EntityDisplayRepositoryInterface::getFormDisplay() instead.
221 Call to deprecated method entityManager() of class Drupal:
in drupal:8.0.0 and is removed from drupal:9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line tests\src\Functional\BoxPlacementTest.php
------ -------------------------------------------------------------------------
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line tests\src\Functional\EntityTest.php
------ -------------------------------------------------------------------------
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line tests\src\Functional\LoadTest.php
------ -------------------------------------------------------------------------
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line tests\src\Functional\TypeTest.php
------ -------------------------------------------------------------------------
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line tests\src\Kernel\BoxValidationTest.php
------ -------------------------------------------------------------------------
Class PHPUnit\Framework\TestCase not found and could not be autoloaded.
------ -------------------------------------------------------------------------

[ERROR] Found 38 errors

neelam_wadhwani’s picture

Assigned: Unassigned » neelam_wadhwani
Issue tags: +VbContribution2020
neelam_wadhwani’s picture

StatusFileSize
new18.78 KB

Kindly review patch.
For error like this - "Class PHPUnit\Framework\TestCase not found and could not be autoloaded.", need to create composer.json.
Will update in next issue.

neelam_wadhwani’s picture

Assigned: neelam_wadhwani » Unassigned
Status: Needs work » Needs review
pasqualle’s picture

Status: Needs review » Needs work

The patch is for a wrong branch.

samvada_jain_m’s picture

Status: Needs work » Needs review
Issue tags: -ContributionWeekend2020, -VbContribution2020
StatusFileSize
new26.69 KB

Please review

pasqualle’s picture

Version: 8.x-2.x-dev » 3.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.