The acquia_spi module logs notices to watchdog using two different type keys. In some places it's watchdog(acquia spi with a space, and in other's it's acquia_spi with an underscore.

Patch provided changes all instances to using the underscore instead of the space, because that is consistent with acquia_purge.

CommentFileSizeAuthor
#4 acquia_connector-consistent_dblog_type-3070729-4.patch4.83 KBjenlampton
#2 acquia_connector-consistent_dblog_type-3070729-2.patch4.92 KBjenlampton

Comments

jenlampton created an issue. See original summary.

jenlampton’s picture

jenlampton
she / her
commented
Assigned: jenlampton » Unassigned
Status: Active » Needs review
StatusFileSize
new acquia_connector-consistent_dblog_type-3070729-2.patch4.92 KB
danepowell’s picture

danepowell commented
Category: Task » Bug report
jenlampton’s picture

jenlampton
she / her
commented
StatusFileSize
new acquia_connector-consistent_dblog_type-3070729-4.patch4.83 KB

Patch rerolled for latest release.

danepowell’s picture

danepowell commented

Thanks for the patch. Note that Acquia Connector 8.x has standardized on the space rather than the underscore, and changing that would be a larger issue.

I'm happy to swing either way on 7.x. Would you rather have consistency with other modules (underscore), or consistency with the 8.x branch (space)?

danepowell’s picture

danepowell commented
Status: Needs review » Postponed (maintainer needs more info)
danepowell’s picture

danepowell commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Closing after a week of inactivity, per the contribution guidelines. Feel free to reopen if you can provide the requested information. Cheers.

jenlampton’s picture

jenlampton
she / her
commented
Status: Closed (outdated) » Active

> I'm happy to swing either way on 7.x. Would you rather have consistency with other modules (underscore), or consistency with the 8.x branch (space)?

I'd rather have consistency with other modules.

> Closing after a week of inactivity, per the contribution guidelines. Feel free to reopen if you can provide the requested information. Cheers.

I will likely only return to this issue after the next release is out to see if the problem has been fixed yet, or not. I understand that this issue may be closed without a fix before then, since I am the only one participating. I will continue to re-open the issue as long as the bug remains (and provide patch updates when necessary), so that other people suffering from the same problem can also benefit from my work.

Patch in #4 still applies to 7.x-3.7 for those who need it.

japerry’s picture

japerry
Location KOMK
commented
Version: 7.x-3.x-dev » 7.x-4.x-dev
Status: Active » Fixed

Fixed in the 4.x version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.