Deprecated function error on uninstall

Hi Kallado,
Thanks for mentioning this. However it has already been fixed. The lines in 8.x-1.0 are

  // Remove our base fields from the schema.
  \Drupal::service('entity.definition_update_manager')->applyUpdates();

But these lines have already been deleted in -dev. Please can you confirm that you are using 8.x-1.0 when this error happened.

Jonathan

Here is the other issye #3038746: Remove deprecated EntityDefinitionUpdateManagerInterface::applyUpdates() from hook_install and hook_uninstall

Hi kallado,
You did not make any mistake. Version 1.0 does have the fault and it is perfectly acceptable to only run full release versions not -dev code.

Scheduler 8.x-1.1 is going to be released soon. You can check the progress on
#3030243: Plan for Scheduler 8.x-1.1 release

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.

This issue is already closed 'works as designed'. There was no fix.

Why did not not read the status and leave it alone. Or maybe these comments were automated, as I have seen dozen's of them in the last two days.

These updates weren't automated. I spent many hours yesterday going through many issues to find ones that had deprecated errors in them. It's useful tagging closed/fixed issues with the tag because then we know the issues were addressed. We're trying to get people contributing to these issues so seeing both open and closed issues with the tag is helpful. It gives us data on progress as well. I won't re-tag this because you don't agree with that and you're maintaining the module.

Wow, I appreciate your effort in doing this. Yes, I am fine with tagging the closed issues when they actually had a deprecation fix. But this one was a duplicate, which had no commit. The real issue was #3038746: Remove deprecated EntityDefinitionUpdateManagerInterface::applyUpdates() from hook_install and hook_uninstall so I have tagged that one instead.

Thanks for your efforts, sorry if I appeared to grumble :-)

Thanks! I definitely don't want to add noise but glad you found an issue to tag. I gathered some stats for a blog post that I hope to get out in a couple days so this is helpful. There's been a lot of work going on to get modules ready for D9 which is good news. Thanks for your help.