If you have set a minimum length for the exposed fulltext filter, and the user enters less than that value, clicking on reset after receiving the "You must include at least one positive keyword with X characters or more." will retrigger the validation, causing an endless loop of error messages.
The include patch checks if the triggering element has the same value as the form reset element value and skips the rest of the validation at that point.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 3070125-7.patch | 762 bytes | rahaf albawab |
| #2 | 3070125-2--views_reset_no_validation.patch | 801 bytes | drunken monkey |
Comments
Comment #2
drunken monkeyThanks a lot for reporting this problem and already providing a patch!
You’re right, I could reproduce the error, and while this is pretty surely a bug in Views itself, not in our module (it stands to reason that the “Reset” button should not trigger any validation at all), it seems sensible to still fix it right here, as there is hardly a chance this would ever get fixed in Views itself.
Your patch just has one problem, namely that it will trigger a notice/warning if the view doesn’t have a “Reset” button. The attached revision should fix that (and also defend against
#triggering_elementnot being there, just to be on the safe side). Please test/review!Comment #3
drunken monkeyCould you please test and/or review?
Comment #5
drunken monkeyComment #7
rahaf albawab commentedThe issue still appear in version 8. I create a new patch to solve the same issue.