------ --------------------------------------------------- 
  Line   ​google_analytics_reports​/​google_analytics_reports_api​/​google_analytics_reports_api.module                               
 ------ --------------------------------------------------- 
  46     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  68     Call to deprecated function file_uri_scheme(). Deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  74     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  125     Call to deprecated function file_uri_scheme(). Deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line  google_analytics_reports​/​google_analytics_reports_api​/​src​/​Form​/​ GoogleAnalyticsReportsApiAdminSettingsForm.php                               
 ------ --------------------------------------------------- 
 196     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
 204     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
                                                                             
 ------ --------------------------------------------------- 
  Line   ​google_analytics_reports​/​src​/​GoogleAnalyticsReports.php                               
 ------ --------------------------------------------------- 
  46     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  49     Call to deprecated function file_uri_scheme(). Deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  53     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  117     Call to deprecated function file_uri_scheme(). Deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  169     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
  174     Call to deprecated function file_uri_scheme(). Deprecated in Drupal 8.0.x-dev, will be removed before Drupal 9.0.0.
 ------ ---------------------------------------------------     

 ------ --------------------------------------------------- 
  Line  ​google_analytics_reports​/​src​/​Plugin​/​views​/​query​/​GoogleAnalyticsQuery.php                               
 ------ --------------------------------------------------- 
 314     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ --------------------------------------------------- 
 368     Call to deprecated function drupal_set_message(). Deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
 ------ ---------------------------------------------------    
                              
 [ERROR] Found 14 error
CommentFileSizeAuthor
#2 3069313-2.patch7.41 KBmohammad-fayoumi

Comments

Mohammad Fayoumi created an issue. See original summary.

mohammad-fayoumi’s picture

mohammad-fayoumi
Primary language English
Location Amman
commented
StatusFileSize
new 3069313-2.patch7.41 KB
mohammad-fayoumi’s picture

mohammad-fayoumi
Primary language English
Location Amman
commented
Status: Active » Needs review
mohammed j. razem’s picture

mohammed j. razem
Location Santa Clara, CA
commented

Looks good. Thanks @Mohammad Fayoumi.

mohammed j. razem’s picture

mohammed j. razem
Location Santa Clara, CA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

hussainweb’s picture

hussainweb
Primary language English
commented 
+++ b/src/Plugin/views/query/GoogleAnalyticsQuery.php
@@ -311,7 +311,7 @@ class GoogleAnalyticsQuery extends QueryPluginBase {
-      drupal_set_message(t('You must <a href=":url">authorize your site</a> to use your Google Analytics account before you can view reports.', [':url' => Url::fromRoute('google_analytics_reports_api.settings')->toString()]));
+      $this->messenger->addMessage(t('You must <a href=":url">authorize your site</a> to use your Google Analytics account before you can view reports.', [':url' => Url::fromRoute('google_analytics_reports_api.settings')->toString()]));
       return;

This is causing fatal errors. The $this->messenger property is never initialised.