The first if/else branch of the changeStatus function looks a bit suspicious, with one being longer than the other.

We should test if the mobile banner behaves correctly and if not provide a patch.

Testing notes:
- Enable Opt-in with categories, Enable floating privacy settings tab and withdraw consent banner and Put the "Withdraw consent" button on the cookie information banner.
- Verify that the banner behaves the same way both for top and bottom positions

CommentFileSizeAuthor
#4 eu_cookie_compliance-fix-top-banner-3069061-4-8.x.patch7.78 KBsvenryen
#4 eu_cookie_compliance-fix-top-banner-3069061-4-7.x.patch8.05 KBsvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
Issue summary: View changes
Status: Active » Needs work
svenryen’s picture

svenryen commented
Status: Needs work » Active
svenryen’s picture

svenryen commented
Title: Fix changeStatus so that the mobile message can be used for top and bottom banner » Fix top banner
StatusFileSize
new eu_cookie_compliance-fix-top-banner-3069061-4-7.x.patch8.05 KB
new eu_cookie_compliance-fix-top-banner-3069061-4-8.x.patch7.78 KB
svenryen’s picture

svenryen commented
Assigned: Unassigned » neslee canil pinto
Status: Active » Needs review
svenryen’s picture

svenryen commented

Test notes:
- Enable withdraw banner, thank you banner
- Set the banner position to top
- Verify that all animations are correct (there won't be an animation between the Thank you and Withdraw banners, and there will be somewhat of a flash as the banners switch, but I think we can just live with that. Probably not many people are using the Thank you banner).

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Fixed

Committed to 7.x and 8.x dev branch. Thank you.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Assigned: neslee canil pinto » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.