Fix Call to deprecated method addAutowiringType() of class Symfony\Component\DependencyInjection\Definition in YamlFileLoader

Imo this is something we fix in drupal 9 by removing this code because it breaks with Symfony 4. We don't want to provide a BC / feature layer for Drupal 9 to support this. And nothing in core actually triggers this error. There's nothing we can do here on d8... people need to do as the deprecation says... Autowiring-types are deprecated since Symfony 3.3 and will be removed in 4.0. Use aliases instead for "%s"...

So I'd recommend moving this issue to Drupal 9.

I expected that this issue would have been solved elsewhere during D9 development, but I just grepped and:

[ibnsina:drupal | Wed 21:30:33] $ grep -r "addAutowiringType" *
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php:                $definition->addAutowiringType($service['autowiring_types']);
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php:                    $definition->addAutowiringType($autowiringType);

Is there something we should try to do here as a beta target? What would a fix look like?

This issue would be sidestepped if we did #3111008: Use native Symfony YamlFileLoader instead.

Cleaning up leftover beta targets from 9.0.x.

Hi,

I am creating a patch for this issue.

Please review the patch.

Let me know for any suggestions.

Thanks.

@Pooja Ganjage what needs to happen here is all of the follow coding removed...

        if (isset($service['autowiring_types'])) {
            if (is_string($service['autowiring_types'])) {
                $definition->addAutowiringType($service['autowiring_types']);
            } else {
                if (!is_array($service['autowiring_types'])) {
                    throw new InvalidArgumentException(sprintf('Parameter "autowiring_types" must be a string or an array for service "%s" in %s. Check your YAML syntax.', $id, $file));
                }

                foreach ($service['autowiring_types'] as $autowiringType) {
                    if (!is_string($autowiringType)) {
                        throw new InvalidArgumentException(sprintf('A "autowiring_types" attribute must be of type string for service "%s" in %s. Check your YAML syntax.', $id, $file));
                    }

                    $definition->addAutowiringType($autowiringType);
                }
            }
        }

It is completely broken in Drupal 9 as $definition->addAutowiringType() does not exist.

The patch looks great, this is the only mention of this feature in core. However, this is also the only place the word "autowiring" appears and so it should be removed from core/misc/cspell/dictionary.txt as part of this patch.

Once this is done this can be marked RTBC.

Addressed #14

Thanks!,

This is a bug. If your services.yml had autowiring_types then this code would trigger an error.

Committed 29397a9 and pushed to 9.2.x. Thanks!

Will backport after 9.1.x alpha and discussion with release managers.

Backported to 9.0.x because this is dead broken code.