In eu_cookie_compliance_user_in_eu, we run SmartIp::query() on the current IP. This breaks the debug feature of Smart IP, and also adds an unnecessary lookup of the geolocation data for the current IP.

D7 doesn't have this problem, so it only needs to be fixed in D8.

Instead, we should get the current values from the smart_ip.smart_ip_location service.

CommentFileSizeAuthor
#2 eu_cookie_compliance-support-smart-ip-debug-mode-and-dont-replicate-lookups-to-smart-ip-that-are-already-done-3068686-2.patch678 bytessvenryen

Comments

svenryen created an issue. See original summary.

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-support-smart-ip-debug-mode-and-dont-replicate-lookups-to-smart-ip-that-are-already-done-3068686-2.patch678 bytes

  • svenryen authored 40b7460 on 8.x-1.x 
    Issue #3068686 by svenryen: Support Smart IP Debug mode and don't...
svenryen’s picture

svenryen commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

progzy’s picture

progzy commented

@svenryen , with this change I can not see the country anymore at "/eu-cookie-compliance-check" (anonymous user). If I revert I can ; that is what I did to keep the banner to show properly.