Hello,

seems the README for d8 file could be a little bit better, guiding the user to the right places. I'll soon post my findings, even though i still haven't managed to make drush working.

thanks!

Comments

joey-santiago created an issue. See original summary.

joey-santiago’s picture

StatusFileSize
new1.1 KB

here's a patch, was indeed quite easy to use this module :)

Webbeh’s picture

Status: Active » Needs review
Webbeh’s picture

StatusFileSize
new3.48 KB
new3.64 KB

#2 needed work.

* Standardized header spacing and formatting.
* Standardized requirements, installation copy.

For review.

karimb’s picture

StatusFileSize
new1.55 KB
new3.78 KB

Nice job of @Webbeh!

I still found some small issues and fix them.

* Change ?<80>? (small arrow) for > (normal arrow)
* Add specific navigation and links for Drupal 8

Need review.

Webbeh’s picture

Status: Needs review » Needs work

Should we remove the D7 documentation from the README (for the 8.x-1.x branch), and just change USAGE (Drupal 8) to USAGE?

mrinalini9’s picture

Assigned: Unassigned » mrinalini9
mrinalini9’s picture

Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new3.5 KB
new516 bytes

Updated patch as per the changes mentioned in #6, please review.

paulocs’s picture

Status: Needs review » Reviewed & tested by the community

The patch #8 looks good!
I think it could have the drupal 8 drush commands on the module page.
At the moment we can only see the commands from drupal 7.
Should I open an issue for it?

Thanks :)

Webbeh’s picture

I think it could have the drupal 8 drush commands on the module page.
At the moment we can only see the commands from drupal 7.
Should I open an issue for it?

That'd be my recommendation. Create a new issue, and reference this one in the OP or related issue.

karimb’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new359 bytes
new3.49 KB

Nice job @mrinalini9, @paulocs and @Webbeh

Small typo fix, "this actions" to "these actions".

-> Needs review.

manav’s picture

Assigned: Unassigned » manav
StatusFileSize
new3.5 KB

The above patch #11 is working fine for me but there is some typo mistake in it.

I have correct it like:

Line no 21: modules that needs to be cleaned

changes to: modules that need to be cleaned

Line no 34: outside of Drupal core.

changes to: outside of the Drupal core.

--> Needs review

manav’s picture

Assigned: manav » Unassigned
Webbeh’s picture

StatusFileSize
new3.62 KB
new1.74 KB

Some small nits to #11, mainly focused on active voice and adding in the menu breadcrumbs alongside the URL slug. For review.

karimb’s picture

Status: Needs review » Reviewed & tested by the community

The patch #14 looks good!

gthing’s picture

Can this be also added to 2.x?

gthing’s picture

Some documentation says you can delete all nodes of a content type with drush delete-all whatevercontenttype. What I'm seeing here doesn't look like it refers to managing specific content types and when executing the command it only asks generically "do you want to delete the node?" I'm not quiteee sure what it's doing...

  • dipakmdhrm committed 601ff50 on 2.x authored by Webbeh
    Issue #3068605 by Webbeh, KarimB, mrinalini9, joey-santiago, Manav,...
dipakmdhrm’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.