| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-3068424-6.txt | 5.21 KB | harshit ghediya |
| #6 | drupal9_readiness-3068424-6.patch | 15.96 KB | harshit ghediya |
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | interdiff-3068424-6.txt | 5.21 KB | harshit ghediya |
| #6 | drupal9_readiness-3068424-6.patch | 15.96 KB | harshit ghediya |
Comments
Comment #2
sergiu stici commentedHere is the patch, please review.
Comment #3
roysegall commentedHi,
I'm Sorry I'm not around here alot. First, thanks for the contribution it still amazes me that someone is using what I initially started.
Second, I need to create a 9.x branch so you can submit the patch against that branch. But first, we need to fix the other tests because composer is failing in installing the dependencies. I kind of got back to do a bit of Drupal lately so I'll try to speed up this one.
Comment #4
dunebl#2 is a very nice patch, unfortunately it is breaking https://www.drupal.org/project/message_ui/issues/3068424#comment-13185860 which is needed.
I think that when everything will be cleared up, this patch should be one of the first to be committed (or one of the last) as it is changing many files and other patch must be insync with those changes
Comment #5
harshit ghediya commentedAdding patch with `core_version_requirement` in below files to make the module D9 compatible.
-> message_ui.info.yml
-> message_notify_ui.info.yml
-> message_ui_test.info.yml
Tested it on D8.9.3 as well as D9, installs successfully after applying the attached patch.
Comment #6
harshit ghediya commentedRe rolling Patch #5
Deprecated class changes in below files :
-> MessageNotifyForm.php
-> DeleteMultiple.php
Comment #7
RiddhiKhetani commentedPatch #6 works for me.
Installed successfully in D9 and works for D8 (8.9.3) as well.
Comment #9
cosolom commentedCommitted. Thanks all