Problem/Motivation

_bs_base_set_yml_value() function is buggy and it will fail in a case when root variable partially exists in yaml file. It should update the variable but currently, it will just add a new version and produce invalid yaml file.

CommentFileSizeAuthor
#7 improve-handling-of-existing-yaml-values-3068227-7.patch3.83 KBpivica
#7 interdiff-3068227-6-7.txt1.44 KBpivica
#6 improve-handling-of-existing-yaml-values-3068227-6.patch3.27 KBpivica
#5 improve-handling-of-existing-yaml-values-3068227-5.patch642 bytespivica
#5 interdiff-3068227-4-5.txt642 bytespivica
#4 improve-handling-of-existing-yaml-values-3068227-4.patch2.77 KBpivica
#4 interdiff-3068227-2-4.txt883 bytespivica
#2 improve-handling-of-existing-yaml-values-3068227-2.patch2.57 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Status: Active » Needs review
Issue tags: +next-release
StatusFileSize
new improve-handling-of-existing-yaml-values-3068227-2.patch2.57 KB

Here is a patch.

sasanikolic’s picture

sasanikolic commented

Tested and works as expected with the patch.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3068227-2-4.txt883 bytes
new improve-handling-of-existing-yaml-values-3068227-4.patch2.77 KB

While debugging another issue i found out that regexp is not catching all possible variations, here is a new patch.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3068227-4-5.txt642 bytes
new improve-handling-of-existing-yaml-values-3068227-5.patch642 bytes

And now i figure it that / delimiter is not good because it's in path also, lets try #.

pivica’s picture

pivica commented
StatusFileSize
new improve-handling-of-existing-yaml-values-3068227-6.patch3.27 KB

The wrong patch attached in last comment, here is correct one.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3068227-6-7.txt1.44 KB
new improve-handling-of-existing-yaml-values-3068227-7.patch3.83 KB

Improved comment a bit and added exception throwing if you try to use anything else then primitive values.

  • pivica committed c6ef619 on 8.x-1.x 
    Issue #3068227 by pivica: Improve _bs_base_set_yml_value() so it can...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.