The functionality tests are deprecated, also a lot of tests are failed.

CommentFileSizeAuthor
#6 conditional_field-update-test-and-fixing-3068112-4.patch378.79 KBnightar
#2 conditional_field-update-test-and-fixing-3068112.patch418.99 KBnightar
#4 conditional_field-update-test-and-fixing-3068112-2.patch238.55 KBnightar

Comments

NightAr created an issue. See original summary.

nightar’s picture

nightar
Primary language English
Location Kharkiv
commented
StatusFileSize
new conditional_field-update-test-and-fixing-3068112.patch418.99 KB

In this patch, I have fixed:
1. Update the tests
2. Fixed the issues during the test running
3. Fixed the support the 'DateTimeList' widget for 'DateTime' field
4. Fixed working the conditions for 'Textarea with summary' field
5. Fixed 'xor' and 'not' conditions for fields.
6. Updated the deprecated methods and functions

nightar’s picture

nightar
Primary language English
Location Kharkiv
commented
nightar’s picture

nightar
Primary language English
Location Kharkiv
commented
StatusFileSize
new conditional_field-update-test-and-fixing-3068112-2.patch238.55 KB

Update the patch file

nightar’s picture

nightar
Primary language English
Location Kharkiv
commented
nightar’s picture

nightar
Primary language English
Location Kharkiv
commented
StatusFileSize
new conditional_field-update-test-and-fixing-3068112-4.patch378.79 KB
itsekhmistro’s picture

itsekhmistro commented
Status: Needs review » Reviewed & tested by the community

  • itsekhmistro committed 70433de on 8.x-1.x authored by NightAr 
    Issue #3068112 by NightAr, itsekhmistro: The tests are deprecated and...
itsekhmistro’s picture

itsekhmistro commented

Committed into 8.x-1.x.

Thank you for your work @NightAr.

itsekhmistro’s picture

itsekhmistro commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Assigned: nightar » colan
Status: Closed (fixed) » Needs work

While important, this commit is causing problems because it was committed before #2926132: OOify contents of conditional_fields.api.inc and then delete it, which I'm now trying to fix. There should be another commit here soon, which will be on the other issue's branch. When everything works, I'll merge it, and then ask folks here to review.

In the future, let's please discuss big commits in #2830988: [meta] 4.0.0 release roadmap as it's taking me a lot of time to unwind this. Thanks!

Questions

  1. Do we still need conditional_fields_load_dependencies_entity() for anything? I can't find any uses anywhere so for now, I'm not porting it to the new ConditionalFieldsFormHelper class that's replacing conditional_fields.api.inc.
  2. Is this a duplicate of #2925924: Get tests working again? I see that issue in #2830988: [meta] 4.0.0 release roadmap, but this one wasn't in there until I added it today.
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

The commit isn't showing up automatically so see Commit 091c8319 for details.

  • colan committed 091c831 on 8.x-1.x 
    Issue #3068112 by colan: Reapply `conditional_fields.api.inc` changes to...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs work » Fixed

Seems to work fine for me, but please reopen if there are any problems.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.