Inline block loading active block_content revision even if serialized block exists

@godotislate thanks for this! Sorry been so long

We need a test to prove the current problem and that we don't regress

This fixes the issue for our project. Thanks @godotislate!

+1

The inline-block form is always loading the active block_content while editing.

Steps to reproduce:

- Navigate to LB page with a content inline-block which is having body field
- Update the body field of the same inline-block and save the changes
- Go to Revert and revert LB page to the previous revision
- See the content was reverted in LB to the previous content.
- Now try to edit the same inline-block.
- It always shows the latest content

Not sure but the issue seems to be in this code:

if (!$this->isNew && !$block->isNew() && empty($this->configuration['block_serialized'])) {
      // Get the active block for editing purposes.
      $block = $this->entityRepository->getActive('block_content', $block->id());
}

Great work @godotislate! RTBC+1!

@ashwinsh could you please test if patch #10 fixes the problem for you?

I am using this Patch for several months now, and got a bug report from a editor, that the content shown in the rendered inline block is not the same as while editing the block. When the block is loaded, there is no serialized content available and the edit-form loads the active revision of the block. The Drupal Core Layout Builder does someting different, it loads the revision referenced in the parent entity:

$entity = $this->entityTypeManager->getStorage('block_content')->loadRevision($this->configuration['block_revision_id']);

This is from getEntity() in core/modules/layout_builder/src/Plugin/Block/InlineBlock.php, and looking further, this method already checks if there is a serialized block, but uses a different method to load the block. So in my case, this still leads to loading of different revisions of the block. Unfortunately I am not sure, what steps lead to it, but I am seeing something similar deleting a translation of a node, an create that translation again.

Revisions for the bundle are enabled, but I am blocking the reverting of revisions and there is no content moderation or workflow with forward revisions.

At this moment, I am not sure, if core should also load the active revision. I am testing overwriting the getEntity()-Method in the InlineBlock-Class from this module for now, to also load the active revision.

For us the patch #10 is working thank you!

#10 is working for us as well — another +1 for RTBC.

I don't think I understand #12 well enough to try to replicate.

Can confirm that #10 is still applying and working for us too. As 3 people confirmed that this is working and the patch contains tests, I'm taking the liberty of marking this as RTBC.

I believe I am seeing the same issues as #12, but for the most part it's working fine. It was reproducible when I had more than two languages.

1. Enable more than 2 languages
2. Create a page in the original language
3. Translate to One of the other languages
4. Translate to the third language

What I was seeing was:

1. Original language is always okay
2. The block description of either of the translated ones would use the text of the previously translated item. For example, set the block translation in french. Then create a spanish version and save the block. The french block description would be the spanish one when viewing, but show the french text when editing.

It appears to be unrelated to this module and there is a thread for what I believe is the same issue here: https://www.drupal.org/project/drupal/issues/3240993

Hiding patches and rolling #10 into an MR.

Thanks for the fixes here.

@heddn, since layout_builder_st 2.0.x pipeline/tests are passing for Drupal 10 and Drupal 11.1 , would be great if you could tag an alpha or beta or rc release for 2.0.x prior to dealing with 11.2/11.3 since we're still using 11.1.9 and a lot of folks are using Drupal 10 still.