I'd like to recommend that https://www.drupal.org/project/r4032login be removed from Guardr since requests to unauthorized routes bootstrap Drupal in order to serve the uncached user login page.

This could add unnecessary load on some sites.

CommentFileSizeAuthor
#8 guardr_core-3067621-disable-r4032login-8.patch449 bytesjoestewart
#6 guardr_core-3067621-disable-r4032login-6.patch401 bytesjoestewart

Comments

bfodeke created an issue. See original summary.

shrop’s picture

shrop commented

I am okay looking at removal. Anyone requiring this for their projects? Are there other ways to accomplish the same thing? Also, if this isn’t enabled by default, maybe we leave it and it is optional. Need to check.

joestewart’s picture

joestewart commented

I believe it is enabled by guardr_core - https://git.drupalcode.org/project/guardr_core/blob/8.x-1.x/guardr_core....

Should this issue be moved there?

And which do you prefer to remove or just leave disabled?

shrop’s picture

shrop commented
Project: Guardr » Guardr Core
Component: Included modules » Code

Moved issue to Guardr Core

shrop’s picture

shrop commented

It was discussed on a Guardr Scrum Meeting to disable the module by default, but leave it there since it is a convenient module for the purposes.

joestewart’s picture

joestewart commented
Status: Active » Needs review
StatusFileSize
new guardr_core-3067621-disable-r4032login-6.patch401 bytes

Patch attached not to enable r4032login by default.

shrop’s picture

shrop commented
Status: Needs review » Needs work

It looks like the patch in #3067621-6: Consider removing r4032login module from Guardr was made against a previous version of the file. Can you take a look at this and confirm you are seeing hte same?

Thanks!

joestewart’s picture

joestewart commented
Status: Needs work » Needs review
StatusFileSize
new guardr_core-3067621-disable-r4032login-8.patch449 bytes

Replaced outdated patch.

  • shrop committed 6e44a3e on 8.x-1.x authored by joestewart 
    Issue #3067621 by joestewart: Consider removing r4032login module from...
shrop’s picture

shrop commented
Status: Needs review » Fixed

Commit to not require the module as a dependency is in 8.x-1.x now. The module is still there if someone wants to use it.

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.