Closed (fixed)
Project:
simplytest.me
Version:
8.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Jul 2019 at 07:07 UTC
Updated:
1 Aug 2019 at 20:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sumitmadan commentedComment #3
sumitmadan commentedUpdate
npm buildcommand in react's package.json, which will generate the build. Rename the theme name as it is conflicting with a profile name and creates issues while accessing libraries.Created a custom block plugin,
idattribute can be set while configuring block.It's not a perfect solution, but it should resolve dependencies on upcoming tasks.
Comment #4
sumitmadan commentedJust noticed that patch is empty. Adding new patch file.
Comment #5
nerdsteinThis looks like a reasonable approach to start with. I am curious how to deploy it. Also, is there a missing config schema?
Comment #6
sumitmadan commentedI don't think we need any config schema here.
To deploy, we need to install the simplytest profile and run
npm buildinside "simplytest_theme/react" directory.Comment #7
nerdsteinPerfect, thanks. I've reviewed once again and there is a ton of front-end changes. At this phase, it's expected. It's nice to see this coming together.
Comment #9
nerdsteinMerged, thanks again!!