Saw the readme is still .txt and readme is missing documentation and formatting according to standards outlined here: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

Patch to follow.

Comments

fayedm created an issue. See original summary.

fayedm’s picture

Assigned: fayedm » Unassigned
Status: Active » Needs review
StatusFileSize
new1.52 KB

Readme.txt removed and Readme.md added in Patch. Ready for Review.

volkswagenchick’s picture

Status: Needs review » Needs work
StatusFileSize
new28.51 KB
+++ b/README.md
@@ -0,0 +1,51 @@
+	2. Navigate to Administration > Configuration > Text formats and editors
+	3. For each text format Configure and select the 'Add noopener to all links'
+	   checkbox and save configuration

Lines 43, 44, 45 look like they have special characters, maybe a "tab"

Also, there should be 4 regular spaces before numbered bullets

Marking as needs work. Please see screenshot

Swapnil_Kotwal’s picture

Assigned: Unassigned » Swapnil_Kotwal
shubham.prakash’s picture

Assigned: Swapnil_Kotwal » Unassigned
Status: Needs work » Needs review
StatusFileSize
new1.53 KB

This patch will fix the mentioned issue.

volkswagenchick’s picture

Status: Needs review » Needs work
+++ b/README.md
@@ -0,0 +1,51 @@
+    3. For each text format Configure and select the 'Add noopener to all links' ¶

Looks like a special character or added space a the end of line 44

shubham.prakash’s picture

Status: Needs work » Needs review
StatusFileSize
new1.53 KB

Here is the fix.

ravi.shankar’s picture

Status: Needs review » Reviewed & tested by the community
volkswagenchick’s picture

Status: Reviewed & tested by the community » Needs review

@shubham.prakash - I see that you are somewhat new to Drupal. Thanks for coming on board and helping the project move forward.

Just FYI - The typical workflow in the issue queue is that if someone posts a patch for review, they do not review it themselves. Having another contributor check out work is an important step in the workflow. It is very similar to our workflow when working on projects, always having a peer review.

I also see that @Swapnil_Kotwal had assigned the issue to themselves, but @shubham.prakash worked on it.. Perhaps there was collaboration, but typically if an issue is assigned to a contributor they post a comment that they will work on the issue or that they are helping another contributor with the process for mentoring. This helps others who look at the issue understand that there is someone working on the task and efforts are not duplicated.

It is also helpful when fixing a minor issue with a patch to upload an interdiff for easier review between two patches. Please visit https://www.drupal.org/documentation/git/interdiff

This issue is similar.
https://www.drupal.org/project/image_scale_and_crop_without_upscale/issu...

Thanks - i am marking this issue back to needs review.

ricardopeters’s picture

@Volkswagenchick, thanks for your contribution and explanation, it clearified some details for me aswell.
I aspire to have a review done somewhere this week, not the fastest, but unfortunately my schedule doesn't allow for any time sooner.

@all your help is greatly appreciated!

redzeuf’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new236.25 KB

I have checked the patch #7 3065979-7.patch, it is good for me. I also checked the #5 that was already good for me, I do not see any specials characters at the end or the start of lines 44 or others. For me, it's a GO.

Here is my screenshot after patch applied:
Screenshot of the patch 5 applied

ricardopeters’s picture

Status: Reviewed & tested by the community » Fixed

Thanks all for you support, I just released the 8.x-1.1 including this update.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.