Closed (fixed)
Project:
Noopener Filter
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Jul 2019 at 00:47 UTC
Updated:
13 Aug 2019 at 08:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
fayedm commentedReadme.txt removed and Readme.md added in Patch. Ready for Review.
Comment #3
volkswagenchickLines 43, 44, 45 look like they have special characters, maybe a "tab"
Also, there should be 4 regular spaces before numbered bullets
Marking as needs work. Please see screenshot
Comment #4
Swapnil_Kotwal commentedComment #5
shubham.prakash commentedThis patch will fix the mentioned issue.
Comment #6
volkswagenchickLooks like a special character or added space a the end of line 44
Comment #7
shubham.prakash commentedHere is the fix.
Comment #8
ravi.shankar commentedComment #9
volkswagenchick@shubham.prakash - I see that you are somewhat new to Drupal. Thanks for coming on board and helping the project move forward.
Just FYI - The typical workflow in the issue queue is that if someone posts a patch for review, they do not review it themselves. Having another contributor check out work is an important step in the workflow. It is very similar to our workflow when working on projects, always having a peer review.
I also see that @Swapnil_Kotwal had assigned the issue to themselves, but @shubham.prakash worked on it.. Perhaps there was collaboration, but typically if an issue is assigned to a contributor they post a comment that they will work on the issue or that they are helping another contributor with the process for mentoring. This helps others who look at the issue understand that there is someone working on the task and efforts are not duplicated.
It is also helpful when fixing a minor issue with a patch to upload an interdiff for easier review between two patches. Please visit https://www.drupal.org/documentation/git/interdiff
This issue is similar.
https://www.drupal.org/project/image_scale_and_crop_without_upscale/issu...
Thanks - i am marking this issue back to needs review.
Comment #10
ricardopeters commented@Volkswagenchick, thanks for your contribution and explanation, it clearified some details for me aswell.
I aspire to have a review done somewhere this week, not the fastest, but unfortunately my schedule doesn't allow for any time sooner.
@all your help is greatly appreciated!
Comment #11
redzeufI have checked the patch #7 3065979-7.patch, it is good for me. I also checked the #5 that was already good for me, I do not see any specials characters at the end or the start of lines 44 or others. For me, it's a GO.
Here is my screenshot after patch applied:

Comment #13
ricardopeters commentedThanks all for you support, I just released the 8.x-1.1 including this update.