Closed (fixed)
Project:
Drupal core
Version:
8.8.x-dev
Component:
content_moderation.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2019 at 07:20 UTC
Updated:
8 Oct 2019 at 10:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
sam152 commentedComment #4
sam152 commentedCredited @mtodor for the original patch. Adding a test for this as well.
The fix itself looks good, restoring the default moderation state on
$original_entitymakes sense to me.Comment #6
alexpottThe test and the change look good.
Looking at a fuller context of the change...
We need to either extend the comment above, Or (probably better) - add a comment above the
else {.Comment #7
sam152 commentedThanks for the review, reflowed and rejigged both comments.
Comment #8
sam152 commentedWhoops, and the patch.
Comment #9
chr.fritschThis is ready to go
Comment #10
alexpottCommitted 884786d and pushed to 8.8.x. Thanks!
Will backport to 8.7.x if the tests are green.
Comment #12
chr.fritschI think the backport should happen here https://www.drupal.org/project/drupal/issues/3065804
Comment #13
alexpottThanks @chr.fritsch