Problem/Motivation

Currently there is the following inline docblock added for the $entity variable in require_on_publish_field_config_submit():

/** @var \Drupal\node\NodeInterface $node */

This seems to be a leftover from previous code, because the $node variable does not exist in the function and the correct variable type for $entity would be \Drupal\field\FieldConfigInterface.

Proposed resolution

  • Use correct inline docblock for $entity in require_on_publish_field_config_submit()

Remaining tasks

  • Provide a patch

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Release notes snippet

Use correct inline docblock for $entity variable in require_on_publish_field_config_submit()

CommentFileSizeAuthor
#2 3065451-2.patch601 byteshctom

Comments

hctom created an issue. See original summary.

hctom’s picture

Status: Active » Needs review
StatusFileSize
new601 bytes

...and here is the proposed patch that should fix the issue.

hctom’s picture

Just a minor one, so let's get this in ;)

mpriscella’s picture

Status: Needs review » Reviewed & tested by the community

  • mpriscella committed e90e0cb on 8.x-1.x authored by hctom
    Issue #3065451 by hctom: Use correct @var inline docblock in...
mpriscella’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.