Problem/Motivation

Currenty the module adds its third-party setting regardless of whether its functionality is enabled or not. This results in an obsolete require_on_publish dependency for every field config upon save.

Proposed resolution

  • Only add the third-party setting if the require on publish functionality is enabled for a field

Remaining tasks

  • Provide a patch

User interface changes

API changes

Data model changes

  • Third-party settings are only saved in field config if necessary

Release notes snippet

CommentFileSizeAuthor
#2 3065449-2.patch673 byteshctom

Comments

hctom created an issue. See original summary.

hctom’s picture

hctom
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 3065449-2.patch673 bytes

...and here is the proposed patch that should fix the issue

hctom’s picture

hctom
Primary language German
commented

Any news on this?! ;)

mlncn’s picture

mlncn commented
Status: Needs review » Reviewed & tested by the community

Been using this patch a while, thanks!

  • mpriscella committed 0cd26e3 on 8.x-1.x authored by hctom 
    Issue #3065449 by hctom: Do not add third-party setting if not used
mpriscella’s picture

mpriscella commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.