Problem/Motivation

The code in date_all_day_field_views_data() has been copied from datetime_field_views_data() a long time ago. Unfortunately this does not handle date ranges correctly as well. It results e.g. in problems using the "Date time range (All day)" end value in views filters, because it is not recognized as datetime.

Proposed resolution

  • Use most current code from datetime_range module's implementation of hook_field_views_data()

Remaining tasks

  • Provide a patch

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Release notes snippet

Use current code for date_all_day_field_views_data()

CommentFileSizeAuthor
#2 3065097.patch2.59 KBhctom

Comments

hctom created an issue. See original summary.

hctom’s picture

hctom
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 3065097.patch2.59 KB

...and here is the proposed patch that should fix the issue

akalam’s picture

akalam commented
Related issues: +#3021557: Make date_all_day a set of widgets and formatters for core's datetime_range field type

Thank you for contributing!
I'm planning to move the date_all_day module to use daterange core's field type, so I hope no hook_field_views_data() will be needed. However I will be back on this issue once the module uses the core field type.

akalam’s picture

akalam commented
Status: Needs review » Fixed

The last 8.x-1.0-beta3 release uses core's daterange field type so I think this issue is fixed. Feel free to reopen the issue if you still having issues in the last release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.