Undefined index notices on cache clear

@Liam Morland, Your patch is working fine & removes the error that shown after clearing the caches. I checked it with the reference of simplytest.me and local & attached the screenshots for the same.

Thanks Liam, and Krina for the RTBC. I'll commit later.

I reviewed the attached patch. In my opinion this issue still needs work.

Let's say you already have a value for "cookie_categories" in the database. What the updated code does is it will first load the popup banner settings from the database, then it adds (and in my opinion overwrites the value coming from the database with) a new value, being NULL.

(Note I haven't run the resulting code after applying your patch, but my impression is that this will happen. Feel free to correct me if I'm wrong).

If we first initialize the default $popup_settings array and then afterwards add the values from the database, we will not have this problem.

Do you agree, Liam? Here's an updated patch. Can somebody review?

+ $popup_settings += variable_get('eu_cookie_compliance', array());

That should be variable_get(...) + $popup_settings to set defaults. The values in that variable will not overwrite what's in $popup_settings.

Does this fix the problem generally or just for a few settings? My site has 40 values in the eu_cookie_compliance variable but this only guarantees 7 exist.

Does this fix the problem generally or just for a few settings? My site has 40 values in the eu_cookie_compliance variable but this only guarantees 7 exist.

I should think so. Most settings have a default fallback when used. But if you say so, it wouldn't hurt to specify all defaults in this function.