Module does not currently comply with coding standards as outlined https://www.drupal.org/docs/develop/standards/coding-standards

FILE: /Users/sean.dietrich/Desktop/drupal/modules/webform_query/README.md
-------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
-------------------------------------------------------------------------
  6 | WARNING | [ ] Line exceeds 80 characters; contains 188 characters
  8 | WARNING | [ ] Line exceeds 80 characters; contains 240 characters
 17 | WARNING | [ ] Line exceeds 80 characters; contains 149 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
 34 | ERROR   | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------


FILE: /Users/sean.dietrich/Desktop/drupal/modules/webform_query/src/WebformQuery.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 49 ERRORS AFFECTING 44 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
   7 | ERROR | [x] Missing class doc comment
   9 | ERROR | [ ] Missing short description in doc comment
  10 | ERROR | [x] Whitespace found at end of line
  10 | ERROR | [x] Expected "\Drupal\Core\Database\Connection" but found "\Drupal\Core\Database\Connection; " for @var tag in member variable comment
  34 | ERROR | [x] Whitespace found at end of line
  35 | ERROR | [ ] Missing short description in doc comment
  35 | ERROR | [x] Whitespace found at end of line
  36 | ERROR | [ ] Missing parameter comment
  36 | ERROR | [x] Expected "int" but found "integer" for parameter type
  41 | ERROR | [x] Whitespace found at end of line
  43 | ERROR | [x] Whitespace found at end of line
  44 | ERROR | [ ] Missing short description in doc comment
  45 | ERROR | [x] Whitespace found at end of line
  47 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  49 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  50 | ERROR | [x] Expected "mixed" but found "type" for parameter type
  51 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  52 | ERROR | [x] Whitespace found at end of line
  59 | ERROR | [ ] key_exists() is a function name alias, use array_key_exists() instead
  62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
  63 | ERROR | [x] Array indentation error, expected 9 spaces but found 8
  64 | ERROR | [x] Array indentation error, expected 9 spaces but found 8
  65 | ERROR | [x] Array indentation error, expected 9 spaces but found 8
  66 | ERROR | [x] Array closing indentation error, expected 7 spaces but found 6
  90 | ERROR | [x] Missing function doc comment
 104 | ERROR | [x] Whitespace found at end of line
 105 | ERROR | [x] Doc comment short description must be on the first line
 106 | ERROR | [x] Whitespace found at end of line
 108 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
 113 | ERROR | [x] Whitespace found at end of line
 122 | ERROR | [x] Whitespace found at end of line
 139 | ERROR | [x] Concat operator must be surrounded by a single space
 140 | ERROR | [x] Concat operator must be surrounded by a single space
 141 | ERROR | [x] Whitespace found at end of line
 148 | ERROR | [x] Concat operator must be surrounded by a single space
 157 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces
 163 | ERROR | [ ] String concat is not required here; use a single string instead
 163 | ERROR | [x] Whitespace found at end of line
 165 | ERROR | [ ] String concat is not required here; use a single string instead
 166 | ERROR | [ ] String concat is not required here; use a single string instead
 174 | ERROR | [x] Whitespace found at end of line
 175 | ERROR | [x] Doc comment short description must be on the first line
 176 | ERROR | [x] Whitespace found at end of line
 177 | ERROR | [ ] Missing parameter comment
 178 | ERROR | [x] Separate the @param and @return sections by a blank line.
 179 | ERROR | [x] Whitespace found at end of line
 179 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
 182 | ERROR | [x] Whitespace found at end of line
 184 | ERROR | [x] Whitespace found at end of line
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 40 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 194ms; Memory: 8Mb

Comments

sean_e_dietrich created an issue. See original summary.

sean_e_dietrich’s picture

Status: Active » Needs review
StatusFileSize
new8.25 KB

Supplying patch to fix coding standards.

cindytwilliams’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new58.27 KB

Patch #2 applied cleanly and fixed coding standards. Screenshot attached of phpcs results showing no errors after applying patch. Marking RTBC.

  • imclean committed e30eee1 on 8.x-1.x
    Issue #3064363 by sean_e_dietrich, cindytwilliams: Coding Standard...
imclean’s picture

Status: Reviewed & tested by the community » Fixed

Thanks. Made changes manually as code had changed slightly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.