On my dev site where showing notices is enabled, there are 3 notices every time I submit the form because first_name, last_name, and company are technically required in the code (they are passed into the Contact constructor whether or not the fields exist).
There's probably a better way to handle this, but for now, I just added an array of required fields to the $fields array and then assign an empty value to $submittedFields for any fields that don't exist. I'll submit a patch shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | constant_contact_block-missing_fields-3064124-5.patch | 860 bytes | amklose |
Comments
Comment #2
replicaobscuraComment #3
mwebaze commented@bmcclure for this particular issue you should have 'constant_contact_block.fields.yml' file in the module. Its in this yml file that the fields are defined. Commenting them out altogether will simply remove them from the form. I probably need to update the documentation on this. Let me know if this helps.
Comment #4
replicaobscuraIt seems to me like the issue here is that, even though you don't have to enable those three fields in the block, the code assumes the fields are always present.
In my opinion, you shouldn't have to manually override the module's .yml file in order to avoid getting PHP notices.
Comment #5
amkloseRerolling patch from #2
Comment #6
mwebaze commentedComment #7
mwebaze commented