Add test coverage for Drupal\views\Plugin\views\field\Counter::getValue()

Here we go....

Hi @lendude, your tests looks good. But I am missing some testing for when the counter_start is used and for when the pager is set to not use the pager's count. Would you like to add those things to the test? If not then the patch is RTBC for me.

@daffie thanks for the review! You are absolutely right, we should add coverage for the counter_start option too, so here we go.

Needed a reroll so no interdiff.

@lendude: The added testing is RTBC for me. I have just one question left. In the counter handler that we now are testing for there is a piece of code and I am not sure if we need to add testing for it. What do you think lendude?

    if ($pager->usePager()) {
      $count += ($pager->getItemsPerPage() * $pager->getCurrentPage() + $pager->getOffset());
    }

Isn't the entire new test method dedicated to that line? The idea was to add coverage for the counter field when using a pager, which is what we are doing here right?
Or am I overlooking something?

ok, then it is RTBC for me.

Needs a re-roll after #3063180: REST views: View result counter shows {{counter}} placeholder when using "data_field" row plugin.

Add the tag.

Here is the patch.

This patch should fix the issue.

@Shubham Prakash: Could you post an interdiff.txt file? See: https://www.drupal.org/documentation/git/interdiff

@Shubham Prakash: Forget about the interdiff.txt file. Thank you for the reroll.

Back to RTBC.

Committed ece5db4 and pushed to 8.8.x. Thanks!