I just found a small coding issue in the EasyBreadcrumbBuilder's applies() method:

 $request = $request = $this->requestStack->getCurrentRequest();

One of $request is unnecessary.

CommentFileSizeAuthor
#2 duplicated-variable-3062768-2.patch590 bytesdenes.szabo

Comments

Denes.Szabo created an issue. See original summary.

denes.szabo’s picture

denes.szabo commented
Assigned: denes.szabo » Unassigned
Status: Active » Needs review
StatusFileSize
new duplicated-variable-3062768-2.patch590 bytes

I just attached my fix.

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Really makes sense.

Good catch!

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Noooo, I would never code that! @RenatoG, feel free to commit.

~G

  • RenatoG committed c4b4b32 on 8.x-1.x authored by Denes.Szabo 
    Issue #3062768 by Denes.Szabo, RenatoG, Greg Boggs: Duplicated $request...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

haha
Committed to the dev branch: 8.x-1.x

Thanks @denesszabo

Best,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.