Closed (fixed)
Project:
Simplenews
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Jun 2019 at 19:43 UTC
Updated:
23 Jul 2019 at 09:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
adamps commentedComment #4
adamps commentedComment #5
adamps commentedComment #6
jonathanshawLooks good Adam, the coverage seems fine.
It took me a little work to figure out how exactly the logic flowed, the following are just some unimportant notes on what might have helped me get it quicker.
The number of users found is not the number the comment leads us to expect.
It took me a while to figure out what was going on in these 2 different slices; it seems fine, albeit could be more explicit.
There's a lot going on in this line.
It would be easier to understand if you moved the slicing to higher up in the function where you first worked on the users.
The significance of array_keys here is not obvious.
Something like:
Comment #7
adamps commentedComment #8
jonathanshawmakes sense
Comment #9
adamps commented