Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#2881212: Formatting guidelines toggle script relies on Classy selectors introduced a change to formatting guidelines markup. This visually breaks Bootstrap styles. Add classes back in Bootstrap to fix the visual regression.
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff_3-5.txt | 819 bytes | Eli-T |
#5 | 3061715_re-add_text_format_classes_removed_from_core-5.patch | 1.31 KB | Eli-T |
#3 | 3061715_re-add_text_format_classes_removed_from_core-3.patch | 1.32 KB | Eli-T |
Screen Shot 2019-06-14 at 01.40.00.png | 51.69 KB | lauriii |
Comments
Comment #2
markhalliwellClasses can be be added back in TextFormat::processElement.
Comment #3
Eli-TClasses re-added as suggested in #2.
Comment #4
markhalliwellThe
addClass
method is very versatile and can help reduce duplication and noise of having to specify the method each time, like is done here. Instead, just call the method once with an array of classes, e.g.$element->format->addClass(['form-inline', 'filter-wrapper']);
Comment #5
Eli-TThanks @markcarver! New patch as suggested in #4.
Comment #8
markhalliwell