While working on #3057148: Add deletePath() method to CollectPathsEvent class we found that Some static event classes test coverage was not as big as desired.

So here i'm opening this issue to increae the test coverage of those classes.

Working on it while we are in Dev Days Transylvania.

CommentFileSizeAuthor
#4 interdiff-3060959-3-4.txt2.37 KBsamuel.mortenson
#4 3060959-4.patch15.81 KBsamuel.mortenson
#3 interdiff.txt1.04 KBplopesc
#3 3060959-event-test-3.patch15.87 KBplopesc
#2 3060959-event-test-2.patch15.79 KBplopesc

Comments

plopesc created an issue. See original summary.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 3060959-event-test-2.patch15.79 KB

Here is a first patch adding tests to Tome Static events following the same pattern in CollectPathsEventTest class.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
StatusFileSize
new 3060959-event-test-3.patch15.87 KB
new interdiff.txt1.04 KB

oh, it seems that Drupal\Tests\token\Kernel\KernelTestBase autocomplete issue bit me again. :/

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new 3060959-4.patch15.81 KB
new interdiff-3060959-3-4.txt2.37 KB

Fixed up some coding standards - but I like this! @plopesc are you planning on doing any additional work on this? If not I'll commit before 1.0. Thanks!

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

Your fixes look totally legit. I just made some mistakes copying & pasting stuff :)

I had no plan to add more test related to event, so from my poin of view, this isue is ready to go.

Thanks!

  • samuel.mortenson authored 812d30d on 8.x-1.x 
    Issue #3060959 by plopesc, samuel.mortenson: Add test coverage for Tome...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.