function features_export_build_form_submit() is too long, and contains logic that should rather be in separate reusable functions.

I am going to give this a try.

CommentFileSizeAuthor
#3 features-7.x-2.x-3060520-3-refactor-features_export_build_form_submit.patch13.23 KBdonquixote

Comments

donquixote created an issue. See original summary.

donquixote’s picture

donquixote commented
Related issues: +#3060521: features_export_build_form_submit() will read + write the same file

An observation I made along the way: #3060521: features_export_build_form_submit() will read + write the same file.

donquixote’s picture

donquixote commented
Status: Active » Needs review
StatusFileSize
new features-7.x-2.x-3060520-3-refactor-features_export_build_form_submit.patch13.23 KB

I would like to provide a patch with a detailed git history.
Unfortunately, format-patch does not capture merges.
It is time we work with real pull requests!
But for the start I simply want to throw something at the testbot.

donquixote’s picture

donquixote commented

Tests are green!
This either means that it works, or that we don't have enough tests :)

I would like to provide a patch with a detailed git history.

Here we go..
https://github.com/donquixote/drupal-features/pull/1

donquixote’s picture

donquixote commented

The next goal of this is to also refactor function _drush_features_export(), reusing some of the functions created in this issue.
But let's start small.