Problem/Motivation

When navigating the autocomplete using the keyboard, selected items are not highlighted.

Remaining tasks

Review patch, commit.

Original report by aiphes

Hi,
Actually coffee on D8 face issues related to the D6 version:

- with keyboard, navigation doesn't active hover effect (mouse do)
- unable to open link in new window, even if I push "ctl"

I will add others if it be necessary.

Thanks

CommentFileSizeAuthor
#2 3059863-coffee-highlighting.patch349 bytesmr.baileys

Comments

aiphes created an issue. See original summary.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Title: Bugs on D8 version of Coffee » Selected link not highlighted when navigating using the keyboard.
Version: 8.x-1.0-beta2 » 8.x-1.x-dev
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3059863-coffee-highlighting.patch349 bytes

Thanks for reporting @aiphes.

In your original issue, you reported 2 separated issues with the module. It is best to create separate issues for each of the bugs, since that makes coordinating and fixing them easier. I have repurposed this issue so it is about the item selection highlighting with the keyboard. I cannot reproduce the second issue you report (On macOS, I can open in a new window if I use ⌘ + click).

Attached is a patch that fixed the missing highlighting when navigating with up- and down-arrows.

aiphes’s picture

aiphes
Primary language French
commented

Thanks for the first fixed issue. I will upgrade to latest dev version as soon as possible.
For the other, ⌘ + click is like CTRL + click on W10 or Linux.
In chrome and FF it does't work, on Edge, Coffee doesn't open...

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented

@aiphes:

I will upgrade to latest dev version as soon as possible.

The fix has not been committed yet, so if you want to use/review/test is, you will have to apply the patch manually (https://www.drupal.org/patch/apply).

Can you open a separate issue for the ctrl+click problem?

  • michaelmol committed c076cf8 on 8.x-1.x authored by mr.baileys 
    Issue #3059863 by mr.baileys, aiphes, michaelmol: Selected link not...
michaelmol’s picture

michaelmol commented
Status: Needs review » Fixed

Thanks

aiphes’s picture

aiphes
Primary language French
commented

@michaelmol: does this signify I can update the module to the new version to fix this ? Which version do I need to use ? dev or stable ?
Thanks

michaelmol’s picture

michaelmol commented

Stable, this fix is included in de 8.x-1.0 version

aiphes’s picture

aiphes
Primary language French
commented

ok just update it to 1.0 and if higlight work, ctl + click or right click doesn't, is it normal ?

aiphes’s picture

aiphes
Primary language French
commented

Another issue, the message Could not load data, please refresh the page is back after update..revert to previous in waiting

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

aiphes’s picture

aiphes
Primary language French
commented

Hi, after upgrade to D885 I get the same message and in watchdog it seem the path is wrong:
/fr/fr/admin/coffee/get-data instead of /fr/admin/coffee/get-data
probably more a Drupal missetting ? but which one ?