I'm seeing a deprecation warning on $entity_type->isSubclassOf('\Drupal\Core\Entity\FieldableEntityInterface') in EntityEmbedDialog.

See change record: https://www.drupal.org/node/2842808

It looks like it just needs to change to entityClassImplements, so should be an easy change.

CommentFileSizeAuthor
#4 3059253-4.patch1.38 KBwim leers
#4 interdiff.txt1.39 KBwim leers
#3 entity_fixes-3059253.patch950 byteskavbiswa

Comments

oknate created an issue. See original summary.

kavbiswa’s picture

kavbiswa commented
Assigned: Unassigned » kavbiswa

I am working on this issue. will update the patch file with the changes.

kavbiswa’s picture

kavbiswa commented
Assigned: kavbiswa » Unassigned
Status: Active » Needs review
StatusFileSize
new entity_fixes-3059253.patch950 bytes

Please find the patch file with the changes. Please review and let me know if any further change is needed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
Issue tags: +@deprecated
StatusFileSize
new interdiff.txt1.39 KB
new 3059253-4.patch1.38 KB

Excellent, thank you very much, @kavbiswa! Just one nitpick which I fixed myself.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

  • Wim Leers committed 739d603 on 8.x-1.x authored by kavbiswa 
    Issue #3059253 by Wim Leers, kavbiswa, oknate: EntityTypeInterface::...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

🚢

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.