Problem/Motivation

Use of static:

  • \Drupal::time();
  • \Drupal::config();

Proposed resolution

Intejct the service datetime.time and use the method $this->config(); of ControllerBase

CommentFileSizeAuthor
#6 captcha-Dependency_injection_on_CaptchaImageRefresh-3057586-2-D8.patch2.4 KBwundo
#5 captcha-Dependency_injection_on_CaptchaImageRefresh-3057586-2-D8.patch2.4 KBwundo
#2 captcha-Dependency_injection_on_CaptchaImageRefresh-3057586-2-D8.patch2.4 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new captcha-Dependency_injection_on_CaptchaImageRefresh-3057586-2-D8.patch2.4 KB

Follow a patch with the injection.

gg24’s picture

gg24 commented
Status: Needs review » Reviewed & tested by the community

Hi @thalles,

The above patch works for me. Hence moving it to RTBC.

Thanks!

wundo’s picture

wundo commented
wundo’s picture

wundo commented
StatusFileSize
new captcha-Dependency_injection_on_CaptchaImageRefresh-3057586-2-D8.patch2.4 KB

re run tests

wundo’s picture

wundo commented
StatusFileSize
new captcha-Dependency_injection_on_CaptchaImageRefresh-3057586-2-D8.patch2.4 KB

re run tests

  • wundo committed c589447 on 8.x-1.x 
    Issue #3057586 by wundo, thalles, gg24: Dependency injection on...
wundo’s picture

wundo commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.