Problem/Motivation

#3053363: Remove support for PHP 5 in Drupal 8.8 added the following change to composer.json:

+++ b/core/composer.json
@@ -17,7 +17,7 @@
         "ext-SPL": "*",
         "ext-tokenizer": "*",
         "ext-xml": "*",
-        "php": "^5.5.9|>=7.0.8",
+        "php": ">=7.0.8",
         "symfony/class-loader": "~3.4.0",
         "symfony/console": "~3.4.0",
         "symfony/dependency-injection": "~3.4.26",

However, this change has not been extended to the resulting composer.lock. As a result, composer.lock has a diff whenever you would run composer update without any changes, such as composer update nothing or composer update --lock.

Proposed resolution

Update composer.lock with the updated PHP requirement.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 3057575-2.patch633 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

Status: Active » Needs review
Related issues: +#3053363: Remove support for PHP 5 in Drupal 8.8
StatusFileSize
new633 bytes

Attached patch is the output of composer update nothing against HEAD.

cilefen’s picture

Status: Needs review » Reviewed & tested by the community

I get the identical change so this is ready if it passes.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c7a275b and pushed to 8.8.x. Thanks!

  • alexpott committed c7a275b on 8.8.x
    Issue #3057575 by idebr: Removal of PHP5 support is not yet reflected...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.