There are a few locations with missing semicolons in JavaScript files.

For sake of consistency, and also to avoid JS aggregation and compression issues, these should be included.

See the attached patch, thanks.

CommentFileSizeAuthor
panels-missing_js_semicolons-1.patch1.54 KBsgdev

Comments

ron_s created an issue. See original summary.

sgdev’s picture

sgdev commented

This patch still works in the latest 7.x-3.10 release. Please review, thanks.

solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community

Looks good and fits the standards.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thank you @ron_s, I've committed to the latest dev release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: » #3157069: Plan for Panels 7.x-3.11